[webkit-changes] [WebKit/WebKit] 5c1022: HighlightRegister should be renamed to HighlightRe...

megangardner noreply at github.com
Wed Oct 4 14:11:49 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5c10221be14f825562feca679a0c80ccb1e513c2
      https://github.com/WebKit/WebKit/commit/5c10221be14f825562feca679a0c80ccb1e513c2
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2023-10-04 (Wed, 04 Oct 2023)

  Changed paths:
    M LayoutTests/highlight/highlight-interfaces-expected.txt
    M LayoutTests/highlight/highlight-interfaces.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/HighlightRegistry-maplike-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/HighlightRegistry-maplike-tampered-Map-prototype.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/idlharness.window-expected.txt
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/DerivedSources-input.xcfilelist
    M Source/WebCore/DerivedSources-output.xcfilelist
    M Source/WebCore/DerivedSources.make
    M Source/WebCore/Headers.cmake
    M Source/WebCore/Modules/highlight/AppHighlightStorage.cpp
    R Source/WebCore/Modules/highlight/HighlightRegister.cpp
    R Source/WebCore/Modules/highlight/HighlightRegister.h
    R Source/WebCore/Modules/highlight/HighlightRegister.idl
    A Source/WebCore/Modules/highlight/HighlightRegistry.cpp
    A Source/WebCore/Modules/highlight/HighlightRegistry.h
    A Source/WebCore/Modules/highlight/HighlightRegistry.idl
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/bindings/js/WebCoreBuiltinNames.h
    M Source/WebCore/css/DOMCSSNamespace.cpp
    M Source/WebCore/css/DOMCSSNamespace.h
    M Source/WebCore/css/DOMCSSNamespace.idl
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/rendering/MarkedText.cpp
    M Source/WebCore/rendering/RenderReplaced.cpp
    M Source/WebCore/testing/Internals.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  -----------
  HighlightRegister should be renamed to HighlightRegistry.
https://bugs.webkit.org/show_bug.cgi?id=262522
rdar://116262991

Reviewed by Aditya Keerthi and Richard Robinson.

HighlightRegister is the old version, need to rename to HighlightRegistry
to be compliant with he current spec.

* Source/WebCore/Modules/highlight/HighlightRegistry.cpp: Renamed from Source/WebCore/Modules/highlight/HighlightRegister.cpp.
(WebCore::HighlightRegistry::initializeMapLike):
(WebCore::HighlightRegistry::setFromMapLike):
(WebCore::HighlightRegistry::clear):
(WebCore::HighlightRegistry::remove):
(WebCore::HighlightRegistry::setHighlightVisibility):
(WebCore::annotationHighlightKey):
(WebCore::HighlightRegistry::addAnnotationHighlightWithRange):
* Source/WebCore/Modules/highlight/HighlightRegistry.h: Renamed from Source/WebCore/Modules/highlight/HighlightRegister.h.
(WebCore::HighlightRegistry::create):
(WebCore::HighlightRegistry::isEmpty const):
(WebCore::HighlightRegistry::highlightsVisibility const):
(WebCore::HighlightRegistry::map const):
(WebCore::HighlightRegistry::highlightNames const):
* Source/WebCore/Modules/highlight/HighlightRegistry.idl: Renamed from Source/WebCore/Modules/highlight/HighlightRegister.idl.

Canonical link: https://commits.webkit.org/268873@main




More information about the webkit-changes mailing list