[webkit-changes] [WebKit/WebKit] a88660: [scroll-anchoring] Implement scroll anchoring for ...

Nikos Mouchtaris noreply at github.com
Wed Oct 4 09:07:37 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a8866055e887ac67d0c7d1ac4a92935469455e8d
      https://github.com/WebKit/WebKit/commit/a8866055e887ac67d0c7d1ac4a92935469455e8d
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2023-10-04 (Wed, 04 Oct 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/accessibility/scroll-to-global-point-iframe-nested.html
    M LayoutTests/accessibility/scroll-to-global-point-nested.html
    M LayoutTests/fast/scrolling/ios/adjust-scroll-snap-during-gesture.html
    M LayoutTests/fast/scrolling/ios/mixing-user-and-programmatic-scroll-002.html
    M LayoutTests/fast/scrolling/ios/mixing-user-and-programmatic-scroll-003.html
    M LayoutTests/fast/scrolling/ios/mixing-user-and-programmatic-scroll-006.html
    M LayoutTests/fast/scrolling/ios/scroll-iframe-001.html
    M LayoutTests/fast/scrolling/ios/scroll-iframe-002.html
    M LayoutTests/fast/scrolling/ios/scroll-iframe-003.html
    M LayoutTests/fast/scrolling/mac/adjust-scroll-snap-during-gesture.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/ancestor-change-heuristic-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/anchor-updates-after-explicit-scroll-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/heuristic-with-offset-update-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/multicol-fragmented-anchor-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/opt-out-dynamic-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/opt-out-dynamic-scroller-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/position-change-heuristic-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/position-change-heuristic-in-nested-scroll-box-expected.txt
    M LayoutTests/scrollingcoordinator/mac/latching/scrolling-select-should-not-latch-mainframe.html
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/page/LocalFrameView.h
    M Source/WebCore/page/scrolling/ScrollAnchoringController.cpp
    M Source/WebCore/page/scrolling/ScrollAnchoringController.h
    M Source/WebCore/platform/ScrollableArea.cpp
    M Source/WebCore/platform/ScrollableArea.h
    M Source/WebCore/rendering/RenderLayerScrollableArea.cpp
    M Source/WebCore/rendering/RenderLayerScrollableArea.h

  Log Message:
  -----------
  [scroll-anchoring] Implement scroll anchoring for subscrollers
https://bugs.webkit.org/show_bug.cgi?id=261775
rdar://115746157

Reviewed by Simon Fraser.

Implement scroll anchoring for subscrollers.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::runScrollSteps):
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::LocalFrameView):
(WebCore::LocalFrameView::scrollPositionChanged):
(WebCore::LocalFrameView::updateScrollAnchoringElementsForScrollableAreas):
(WebCore::LocalFrameView::invalidateScrollAnchoringElement): Deleted.
(WebCore::LocalFrameView::updateScrollAnchoringElement): Deleted.
(WebCore::LocalFrameView::updateScrollPositionForScrollAnchoringController): Deleted.
* Source/WebCore/page/LocalFrameView.h:
* Source/WebCore/page/scrolling/ScrollAnchoringController.cpp:
(WebCore::ScrollAnchoringController::ScrollAnchoringController):
(WebCore::ScrollAnchoringController::invalidateAnchorElement):
(WebCore::ScrollAnchoringController::updateAnchorElement):
(WebCore::ScrollAnchoringController::adjustScrollPositionForAnchoring):
* Source/WebCore/page/scrolling/ScrollAnchoringController.h:
* Source/WebCore/platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::setScrollAnchoringController):
(WebCore::ScrollableArea::scrollAnchoringController):
(WebCore::ScrollableArea::scrollPositionChanged):
(WebCore::ScrollableArea::updateScrollAnchoringElement):
(WebCore::ScrollableArea::updateScrollPositionForScrollAnchoringController):
(WebCore::ScrollableArea::invalidateScrollAnchoringElement):
* Source/WebCore/platform/ScrollableArea.h:
(WebCore::ScrollableArea::updateScrollAnchoringElement): Deleted.
(WebCore::ScrollableArea::updateScrollPositionForScrollAnchoringController): Deleted.
* Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::RenderLayerScrollableArea):

Canonical link: https://commits.webkit.org/268848@main




More information about the webkit-changes mailing list