[webkit-changes] [WebKit/WebKit] 17d73b: Getting function name that includes space return e...

Commit Queue noreply at github.com
Wed Oct 4 02:05:44 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 17d73b1570a460060f36fc3cc9fa6b281e7dd0e5
      https://github.com/WebKit/WebKit/commit/17d73b1570a460060f36fc3cc9fa6b281e7dd0e5
  Author: Mark Lam <mark.lam at apple.com>
  Date:   2023-10-04 (Wed, 04 Oct 2023)

  Changed paths:
    R LayoutTests/js/dom/regress-157246-expected.txt
    R LayoutTests/js/dom/regress-157246.html
    R LayoutTests/js/dom/script-tests/regress-157246.js
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/JavaScriptCore/runtime/JSFunction.cpp
    M Source/JavaScriptCore/runtime/JSFunctionInlines.h

  Log Message:
  -----------
  Getting function name that includes space return empty string.
https://bugs.webkit.org/show_bug.cgi?id=262123
rdar://116406865

Reviewed by Yusuke Suzuki.

http://trac.webkit.org/r200423 introduced a site specific quirk (introduced back in 2016) to work around
the mathjs framework (at https://github.com/josdejong/mathjs) not supporting ES6 function names that
can contain white space.  See https://bugs.webkit.org/show_bug.cgi?id=157246.

Now that mathjs no longer has the offending code, plus both Chrome and Firefox also implements the ES6
spec on this, it's time to remove this quirk.

* LayoutTests/js/dom/regress-157246-expected.txt: Removed.
* LayoutTests/js/dom/regress-157246.html: Removed.
* LayoutTests/js/dom/script-tests/regress-157246.js: Removed.
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/JavaScriptCore/runtime/JSFunction.cpp:
(JSC::JSFunction::reifyName):
* Source/JavaScriptCore/runtime/JSFunctionInlines.h:
(JSC::JSFunction::originalName):

Canonical link: https://commits.webkit.org/268838@main




More information about the webkit-changes mailing list