[webkit-changes] [WebKit/WebKit] fa9c96: [WGSL] Initial plumbing for evaluating override ex...

Tadeu Zagallo noreply at github.com
Wed Oct 4 01:25:15 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fa9c962a0aee56992300252665f4be6ef4535620
      https://github.com/WebKit/WebKit/commit/fa9c962a0aee56992300252665f4be6ef4535620
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-10-04 (Wed, 04 Oct 2023)

  Changed paths:
    M Source/WebGPU/WGSL/EntryPointRewriter.cpp
    M Source/WebGPU/WGSL/WGSL.cpp
    M Source/WebGPU/WGSL/WGSL.h
    M Source/WebGPU/WebGPU/ComputePipeline.mm
    M Source/WebGPU/WebGPU/Pipeline.h
    M Source/WebGPU/WebGPU/Pipeline.mm
    M Source/WebGPU/WebGPU/RenderPipeline.mm

  Log Message:
  -----------
  [WGSL] Initial plumbing for evaluating override expressions from the API
https://bugs.webkit.org/show_bug.cgi?id=262562
rdar://116414218

Reviewed by Mike Wyrzykowski.

The API needs to be able to evaluate override expressions for e.g. attributes and
override variable initializer expressions. This is first step in that direction,
which exposes a (currently very limited) function to evaluate expressions from the
API. This initial implementation, although very basic, should unblock some of the
samples that require resolving override variables in the workgroup_size attribute.

* Source/WebGPU/WGSL/EntryPointRewriter.cpp:
(WGSL::EntryPointRewriter::EntryPointRewriter):
* Source/WebGPU/WGSL/WGSL.cpp:
(WGSL::evaluate):
* Source/WebGPU/WGSL/WGSL.h:
* Source/WebGPU/WebGPU/ComputePipeline.mm:
(WebGPU::createComputePipelineState):
(WebGPU::metalSize):
(WebGPU::Device::createComputePipeline):
* Source/WebGPU/WebGPU/Pipeline.h:
* Source/WebGPU/WebGPU/Pipeline.mm:
(WebGPU::createConstantValues):
(WebGPU::createFunction):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipeline):

Canonical link: https://commits.webkit.org/268833@main




More information about the webkit-changes mailing list