[webkit-changes] [WebKit/WebKit] 7db16b: [iOS] Remove usages of `-[UIWKTextInteractionAssis...

Wenson Hsieh noreply at github.com
Tue Oct 3 21:12:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7db16bef2098ad93c8c3d63c5af5f7e385d43c98
      https://github.com/WebKit/WebKit/commit/7db16bef2098ad93c8c3d63c5af5f7e385d43c98
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-10-03 (Tue, 03 Oct 2023)

  Changed paths:
    M Source/WebKit/Platform/spi/ios/UIKitSPI.h
    M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  [iOS] Remove usages of `-[UIWKTextInteractionAssistant (show|hide)TextStyleOptions]`
https://bugs.webkit.org/show_bug.cgi?id=262596

Reviewed by Richard Robinson.

These SPI methods have been no-ops since iOS 16; there's no point in calling into them anymore.

Support for text style options is now entirely in UIKit menu code, via the `UIMenuFormat` menu and
its sub-items, which invoke `-toggleBoldface:`, `-toggleItalics:`, and `-toggleUnderline:`
respectively.

* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setUpInteraction]):
(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView _didHideMenu:]): Deleted.
(-[WKContentView _showTextStyleOptionsForWebView:]): Deleted.

Canonical link: https://commits.webkit.org/268825@main




More information about the webkit-changes mailing list