[webkit-changes] [WebKit/WebKit] 9b9546: Mixed content checker should not hang in site isol...

Alex Christensen noreply at github.com
Tue Oct 3 18:10:44 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b95468b01eb6f0f63974e17218b539338e5a83b
      https://github.com/WebKit/WebKit/commit/9b95468b01eb6f0f63974e17218b539338e5a83b
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-10-03 (Tue, 03 Oct 2023)

  Changed paths:
    A LayoutTests/http/tests/site-isolation/https-load-expected.txt
    A LayoutTests/http/tests/site-isolation/https-load.html
    A LayoutTests/http/tests/site-isolation/resources/fetch-https.html
    M Source/WebCore/loader/MixedContentChecker.cpp

  Log Message:
  -----------
  Mixed content checker should not hang in site isolated iframes
https://bugs.webkit.org/show_bug.cgi?id=262581
rdar://116430288

Reviewed by Pascoe.

When loading any https resource in a site-isolated https iframe, we would hang the process
because foundMixedContentInFrameTree doesn't update its document pointer in the loop.
This makes the load succeed so we can investigate other things with site isolation, with
future work to be done to make the mixed content checks actually correct.

* LayoutTests/http/tests/site-isolation/https-load-expected.txt: Added.
* LayoutTests/http/tests/site-isolation/https-load.html: Added.
* LayoutTests/http/tests/site-isolation/resources/fetch-https.html: Added.
* Source/WebCore/loader/MixedContentChecker.cpp:
(WebCore::foundMixedContentInFrameTree):

Canonical link: https://commits.webkit.org/268816@main




More information about the webkit-changes mailing list