[webkit-changes] [WebKit/WebKit] 86a15e: Page document and frame loops should traverse from...

Charlie Wolfe noreply at github.com
Tue Oct 3 12:18:30 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 86a15eb9f4a9b00b7fa0e141e57d643a7316b8bf
      https://github.com/WebKit/WebKit/commit/86a15eb9f4a9b00b7fa0e141e57d643a7316b8bf
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2023-10-03 (Tue, 03 Oct 2023)

  Changed paths:
    M Source/WebCore/inspector/agents/InspectorApplicationCacheAgent.cpp
    M Source/WebCore/inspector/agents/page/PageRuntimeAgent.cpp
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/Page.h

  Log Message:
  -----------
  Page document and frame loops should traverse from the remote main frame
https://bugs.webkit.org/show_bug.cgi?id=262513
rdar://116374168

Reviewed by Alex Christensen.

Several things rely on the document and frame loops in `WebCore::Page` which begin traversing from the
main frame. With site isolation, the main frame may be in a different process, so the frame traversal
will never happen. We should do this traversal even if the main frame is remote.

Also rename forEachFrame to forEachLocalFrame.

* Source/WebCore/inspector/agents/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
* Source/WebCore/inspector/agents/page/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::reportExecutionContextCreation):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::~Page):
(WebCore::Page::notifyToInjectUserScripts):
(WebCore::Page::forEachDocumentFromMainFrame):
(WebCore::Page::forEachDocument const):
(WebCore::Page::forEachLocalFrame):
(WebCore::Page::forEachFrame): Deleted.
* Source/WebCore/page/Page.h:

Canonical link: https://commits.webkit.org/268798@main




More information about the webkit-changes mailing list