[webkit-changes] [WebKit/WebKit] e0366a: Remove BBC radio player quirk leftovers

Olivier Blin noreply at github.com
Tue Oct 3 05:24:40 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e0366ad8cf403e21b813ddd94bc2441d27c60fa4
      https://github.com/WebKit/WebKit/commit/e0366ad8cf403e21b813ddd94bc2441d27c60fa4
  Author: Olivier Blin <olivier.blin at softathome.com>
  Date:   2023-10-03 (Tue, 03 Oct 2023)

  Changed paths:
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/Quirks.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  Remove BBC radio player quirk leftovers
https://bugs.webkit.org/show_bug.cgi?id=262300

Reviewed by Kate Cheney and Brent Fulgham.

The BBC radio player quirk has been removed in 266597 at main (9b58b4b),
which is a back-merge of 259548.824 at safari-7615-branch (cff01e3).

But this commit did not remove the Quirks::staticRadioPlayerURLString() method
initially removed, and a second quirk part added in 261190 at main (ae69009)
which is now irrelevant and potentially broken.

The usage of staticRadioPlayerURLString() also broke build without ITP support.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::staticRadioPlayerURLString): Deleted.
* Source/WebCore/page/Quirks.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createNewPage):

Canonical link: https://commits.webkit.org/268769@main




More information about the webkit-changes mailing list