[webkit-changes] [WebKit/WebKit] 7e0cd0: formAssociated=true shouldn’t cause custom element...

sideshowbarker noreply at github.com
Mon Oct 2 16:21:02 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7e0cd07bab81cbd7cc043a2db4586136ca1d1307
      https://github.com/WebKit/WebKit/commit/7e0cd07bab81cbd7cc043a2db4586136ca1d1307
  Author: Michael[tm] Smith <mike at w3.org>
  Date:   2023-10-02 (Mon, 02 Oct 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/focusability-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/focusability.html
    M Source/WebCore/html/HTMLMaybeFormAssociatedCustomElement.cpp

  Log Message:
  -----------
  formAssociated=true shouldn’t cause custom element to become focusable
https://bugs.webkit.org/show_bug.cgi?id=261621

Reviewed by Ryosuke Niwa.

This change fixes a bug that caused any custom element to become
focusable just by setting its formAssociated value to true — even if the
custom element doesn’t have a tabindex value.

* LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/focusability-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/focusability.html: Added.
* Source/WebCore/html/HTMLMaybeFormAssociatedCustomElement.cpp:
(WebCore::HTMLMaybeFormAssociatedCustomElement::supportsFocus const):

Canonical link: https://commits.webkit.org/268756@main




More information about the webkit-changes mailing list