[webkit-changes] [WebKit/WebKit] 6e6c49: [commits.webkit.org] Add ability to block user agents

Jonathan Bedard noreply at github.com
Mon Oct 2 11:54:06 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6e6c491c33087f64beffcf48de3d03587412ff31
      https://github.com/WebKit/WebKit/commit/6e6c491c33087f64beffcf48de3d03587412ff31
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2023-10-02 (Mon, 02 Oct 2023)

  Changed paths:
    M Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py
    M Tools/Scripts/libraries/reporelaypy/reporelaypy/checkoutroute.py
    M Tools/Scripts/libraries/reporelaypy/reporelaypy/webserver.py
    M Tools/Scripts/libraries/reporelaypy/run
    M Tools/Scripts/libraries/reporelaypy/setup.py
    M Tools/Scripts/libraries/webkitflaskpy/setup.py
    M Tools/Scripts/libraries/webkitflaskpy/webkitflaskpy/__init__.py
    M Tools/Scripts/libraries/webkitflaskpy/webkitflaskpy/authed_blueprint.py

  Log Message:
  -----------
  [commits.webkit.org] Add ability to block user agents
https://bugs.webkit.org/show_bug.cgi?id=262236
rdar://116155811

Reviewed by Aakash Jain and Elliott Williams.

Some user agents (particularly search engine spiders) should not be accessing
the redirect endpoints of commits.webkit.org. Those endpoints just redirect to
GitHub, which is presumably where the crawlers got the links in the first place.

* Tools/Scripts/libraries/reporelaypy/setup.py: Bump version.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py: Ditto.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/checkoutroute.py:
(CheckoutRoute.__init__): Pass blocked user agents to base class.
* Tools/Scripts/libraries/webkitflaskpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitflaskpy/webkitflaskpy/__init__.py: Ditto.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/webserver.py: Extract blocked
user agents from environment.
* Tools/Scripts/libraries/reporelaypy/run:
(main): Fix local run command.
* Tools/Scripts/libraries/webkitflaskpy/webkitflaskpy/authed_blueprint.py:
(AuthedBlueprint):
(AuthedBlueprint.blocked_user_agent_decorator): Return method which checks user agent
before invoking the provided method.
(AuthedBlueprint.__init__): Accept list of user agents to block.
(AuthedBlueprint.add_url_rule): Check user agent before invoking the provided method.

Canonical link: https://commits.webkit.org/268740@main




More information about the webkit-changes mailing list