[webkit-changes] [WebKit/WebKit] 153988: [WGSL] Override initializers should not be serialized

Tadeu Zagallo noreply at github.com
Mon Oct 2 01:41:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1539889e57a392c6943abb92e81570730af480bf
      https://github.com/WebKit/WebKit/commit/1539889e57a392c6943abb92e81570730af480bf
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-10-02 (Mon, 02 Oct 2023)

  Changed paths:
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp

  Log Message:
  -----------
  [WGSL] Override initializers should not be serialized
https://bugs.webkit.org/show_bug.cgi?id=262385
rdar://116246863

Reviewed by Mike Wyrzykowski.

A one line fix to unbreak the shadowMapping WebGPU sample. In order to implement this
properly we also need to expose the default value to the API, which gets a little more
complicated since the default value can be an expression that depends on other values,
so for now this is enough to get the demo working, and we'll implement the rest in a
follow-up patch.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::serializeVariable):

Canonical link: https://commits.webkit.org/268718@main




More information about the webkit-changes mailing list