[webkit-changes] [WebKit/WebKit] d3c6d5: Adopt more smart pointers in editing code

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d3c6d562070aae58ed3422466e1cb518c57acb01
      https://github.com/WebKit/WebKit/commit/d3c6d562070aae58ed3422466e1cb518c57acb01
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-10-01 (Sun, 01 Oct 2023)

  Changed paths:
    M Source/WebCore/editing/EditingStyle.cpp
    M Source/WebCore/editing/Editor.cpp
    M Source/WebCore/editing/EditorCommand.cpp
    M Source/WebCore/editing/FormatBlockCommand.cpp
    M Source/WebCore/editing/FormatBlockCommand.h
    M Source/WebCore/editing/FrameSelection.cpp
    M Source/WebCore/editing/FrameSelection.h
    M Source/WebCore/editing/InsertIntoTextNodeCommand.cpp
    M Source/WebCore/editing/InsertIntoTextNodeCommand.h
    M Source/WebCore/editing/InsertLineBreakCommand.cpp
    M Source/WebCore/editing/InsertNodeBeforeCommand.cpp
    M Source/WebCore/editing/InsertNodeBeforeCommand.h
    M Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp
    M Source/WebCore/editing/InsertParagraphSeparatorCommand.h
    M Source/WebCore/editing/InsertTextCommand.cpp
    M Source/WebCore/editing/MarkupAccumulator.cpp
    M Source/WebCore/editing/MergeIdenticalElementsCommand.cpp
    M Source/WebCore/editing/MergeIdenticalElementsCommand.h
    M Source/WebCore/editing/MoveSelectionCommand.cpp
    M Source/WebCore/editing/RemoveFormatCommand.cpp
    M Source/WebCore/editing/RemoveNodeCommand.cpp
    M Source/WebCore/editing/RemoveNodeCommand.h
    M Source/WebCore/editing/RemoveNodePreservingChildrenCommand.cpp
    M Source/WebCore/editing/RemoveNodePreservingChildrenCommand.h
    M Source/WebCore/editing/RenderedPosition.cpp
    M Source/WebCore/editing/RenderedPosition.h
    M Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp
    M Source/WebCore/editing/ReplaceNodeWithSpanCommand.h
    M Source/WebCore/editing/ReplaceRangeWithTextCommand.cpp
    M Source/WebCore/editing/ReplaceRangeWithTextCommand.h
    M Source/WebCore/editing/ReplaceSelectionCommand.cpp
    M Source/WebCore/editing/ReplaceSelectionCommand.h
    M Source/WebCore/editing/SpellingCorrectionCommand.cpp
    M Source/WebCore/editing/markup.cpp
    M Source/WebCore/rendering/RenderObject.h
    M Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm

  Log Message:
  -----------
  Adopt more smart pointers in editing code
https://bugs.webkit.org/show_bug.cgi?id=262452

Reviewed by Ryosuke Niwa.

* Source/WebCore/editing/EditingStyle.cpp:
(WebCore::identifierForStyleProperty):
(WebCore::fontWeightValueIsBold):
(WebCore::EditingStyle::extractFontSizeDelta):
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement const):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::styleAtSelectionStart):
(WebCore::EditingStyle::inverseTransformColorIfNeeded):
(WebCore::StyleChange::StyleChange):
(WebCore::backgroundColorInEffect):
* Source/WebCore/editing/Editor.cpp:
(WebCore::imageElementFromImageDocument):
(WebCore::Editor::canPaste const):
(WebCore::Editor::shouldInsertText const):
(WebCore::Editor::hasBidiSelection const):
(WebCore::Editor::postTextStateChangeNotificationForCut):
(WebCore::Editor::quoteFragmentForPasting):
(WebCore::Editor::baseWritingDirectionForSelectionStart const):
(WebCore::Editor::setComposition):
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::markMisspellingsOrBadGrammar):
(WebCore::Editor::rangeForPoint):
(WebCore::isFrameInRange):
(WebCore::editableTextListsAtPositionInDescendingOrder):
* Source/WebCore/editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance):
(WebCore::executeInsertNewline):
(WebCore::valueFormatBlock):
* Source/WebCore/editing/FormatBlockCommand.cpp:
(WebCore::FormatBlockCommand::formatRange):
(WebCore::FormatBlockCommand::elementForFormatBlockCommand):
* Source/WebCore/editing/FormatBlockCommand.h:
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::DragCaretController::caretRectInRootViewCoordinates const):
(WebCore::DragCaretController::editableElementRectInRootViewCoordinates const):
(WebCore::DragCaretController::setCaretPosition):
(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance):
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::updateSelectionAppearanceNow):
(WebCore::FrameSelection::respondToNodeModification):
(WebCore::adjustPositionForUserSelectAll):
(WebCore::repaintCaretForLocalRect):
(WebCore::FrameSelection::recomputeCaretRect):
(WebCore::CaretBase::invalidateCaretRect):
(WebCore::CaretBase::paintCaret const):
(WebCore::FrameSelection::contains const):
(WebCore::FrameSelection::selectFrameElementInParentIfFullySelected):
(WebCore::FrameSelection::selectAll):
(WebCore::FrameSelection::focusedOrActiveStateChanged):
(WebCore::FrameSelection::updateAppearance):
(WebCore::FrameSelection::selectionBounds):
(WebCore::scanForForm):
(WebCore::FrameSelection::currentForm const):
(WebCore::FrameSelection::setSelectionFromNone):
(WebCore::FrameSelection::dispatchSelectStart):
(WebCore::FrameSelection::setShouldShowBlockCursor):
* Source/WebCore/editing/FrameSelection.h:
* Source/WebCore/editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doReapply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):
(WebCore::InsertIntoTextNodeCommand::getNodesInCommand):
* Source/WebCore/editing/InsertIntoTextNodeCommand.h:
(WebCore::InsertIntoTextNodeCommand::protectedNode const):
* Source/WebCore/editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::doApply):
* Source/WebCore/editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):
* Source/WebCore/editing/InsertNodeBeforeCommand.h:
(WebCore::InsertNodeBeforeCommand::protectedInsertChild const):
* Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::highestVisuallyEquivalentDivBelowRoot):
(WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion):
(WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion):
(WebCore::InsertParagraphSeparatorCommand::doApply):
* Source/WebCore/editing/InsertParagraphSeparatorCommand.h:
(WebCore::InsertParagraphSeparatorCommand::protectedStyle const):
* Source/WebCore/editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::insertTab):
* Source/WebCore/editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::serializeNodesWithNamespaces):
(WebCore::MarkupAccumulator::entityMaskForText const):
(WebCore::MarkupAccumulator::xmlAttributeSerialization):
* Source/WebCore/editing/MergeIdenticalElementsCommand.cpp:
(WebCore::MergeIdenticalElementsCommand::doApply):
(WebCore::MergeIdenticalElementsCommand::doUnapply):
* Source/WebCore/editing/MergeIdenticalElementsCommand.h:
(WebCore::MergeIdenticalElementsCommand::protectedElement1 const):
(WebCore::MergeIdenticalElementsCommand::protectedElement2 const):
* Source/WebCore/editing/RemoveFormatCommand.cpp:
(WebCore::RemoveFormatCommand::doApply):
* Source/WebCore/editing/RemoveNodeCommand.cpp:
(WebCore::RemoveNodeCommand::doApply):
(WebCore::RemoveNodeCommand::doUnapply):
* Source/WebCore/editing/RemoveNodeCommand.h:
(WebCore::RemoveNodeCommand::protectedNode const):
* Source/WebCore/editing/RemoveNodePreservingChildrenCommand.cpp:
(WebCore::RemoveNodePreservingChildrenCommand::doApply):
* Source/WebCore/editing/RemoveNodePreservingChildrenCommand.h:
(WebCore::RemoveNodePreservingChildrenCommand::portectedNode const):
* Source/WebCore/editing/RenderedPosition.cpp:
(WebCore::rendererFromPosition):
(WebCore::RenderedPosition::positionAtLeftBoundaryOfBiDiRun const):
(WebCore::RenderedPosition::positionAtRightBoundaryOfBiDiRun const):
* Source/WebCore/editing/RenderedPosition.h:
* Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
(WebCore::ReplaceNodeWithSpanCommand::doApply):
(WebCore::ReplaceNodeWithSpanCommand::doUnapply):
* Source/WebCore/editing/ReplaceNodeWithSpanCommand.h:
(WebCore::ReplaceNodeWithSpanCommand::protectedSpanElement const):
(WebCore::ReplaceNodeWithSpanCommand::protectedElementToReplace const):
* Source/WebCore/editing/ReplaceRangeWithTextCommand.cpp:
(WebCore::ReplaceRangeWithTextCommand::inputEventDataTransfer const):
* Source/WebCore/editing/ReplaceRangeWithTextCommand.h:
(WebCore::ReplaceRangeWithTextCommand::protectedTextFragment const):
* Source/WebCore/editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::protectedFragment const):
(WebCore::positionAvoidingPrecedingNodes):
(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplacementFragment::removeNode):
(WebCore::ReplacementFragment::insertNodeBefore):
(WebCore::ReplacementFragment::insertFragmentForTestRendering):
(WebCore::ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment):
(WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
(WebCore::fragmentNeedsColorTransformed):
(WebCore::ReplaceSelectionCommand::moveNodeOutOfAncestor):
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
(WebCore::handleStyleSpansBeforeInsertion):
(WebCore::isInlineNodeWithStyle):
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):
(WebCore::ReplaceSelectionCommand::mergeTextNodesAroundPosition):
(WebCore::singleChildList):
(WebCore::deepestSingleChildList):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
(WebCore::ReplaceSelectionCommand::ensureReplacementFragment):
* Source/WebCore/editing/ReplaceSelectionCommand.h:
* Source/WebCore/editing/markup.cpp:
(WebCore::createPageForSanitizingWebContent):
(WebCore::styleFromMatchedRulesAndInlineDecl):
(WebCore::collectElementsToRemoveFromFragment):
(WebCore::replaceChildrenWithFragment):
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::protectedNode const):
* Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation currentForm]):

Canonical link: https://commits.webkit.org/268709@main