[webkit-changes] [WebKit/WebKit] 76c6ef: Element.setAttributeNode() should not treat attrib...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 76c6ef3c49b0b531921164ecac9087df29e76cff
      https://github.com/WebKit/WebKit/commit/76c6ef3c49b0b531921164ecac9087df29e76cff
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-11-30 (Thu, 30 Nov 2023)

  Changed paths:
    M LayoutTests/fast/dom/Attr/make-unique-element-data-while-replacing-attr.html
    M LayoutTests/fast/dom/Element/setAttributeNode-overriding-lowercase-values-2-expected.txt
    M LayoutTests/fast/dom/Element/setAttributeNode-overriding-lowercase-values-2.html
    M LayoutTests/imported/w3c/web-platform-tests/dom/nodes/attributes-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/nodes/attributes.html
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/Element.h

  Log Message:
  -----------
  Element.setAttributeNode() should not treat attribute names case insensitively
https://bugs.webkit.org/show_bug.cgi?id=265597

Reviewed by Brent Fulgham.

Stop treating the attribute names insensitively in Element.setAttributeNode() as this didn't
match the DOM specification [1] or the behavior of Chrome / Firefox.

Thanks to Claudio Saavedra from Igalia for finding the bug and starting the investigation
on this.

[1] https://dom.spec.whatwg.org/#dom-element-setattributenode

* LayoutTests/imported/w3c/web-platform-tests/dom/nodes/attributes-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/nodes/attributes.html:
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::setAttributeNode):
* Source/WebCore/dom/Element.h:

Canonical link: https://commits.webkit.org/271363@main