[webkit-changes] [WebKit/WebKit] 82a9b6: EWS shouldn't rely on getting JSONP layout tests r...

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 82a9b67dbeea7129c871d30079df408fc127d066
      https://github.com/WebKit/WebKit/commit/82a9b67dbeea7129c871d30079df408fc127d066
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2023-11-30 (Thu, 30 Nov 2023)

  Changed paths:
    M Tools/CISupport/ews-build/layout_test_failures.py
    A Tools/CISupport/ews-build/layout_test_failures_unittest.py
    M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  -----------
  EWS shouldn't rely on getting JSONP layout tests results
https://bugs.webkit.org/show_bug.cgi?id=265606

Reviewed by Jonathan Bedard.

Instead of erroring if we don't have JSONP, match webkitpy
(webkitpy.layout_tests.layout_package.json_results_generator) behaviour
of optionally stripping the JSONP wrapper and then failing if we can't
actually parse the JSON.

* Tools/CISupport/ews-build/layout_test_failures.py:
(LayoutTestFailures._strip_json_wrapper):
(LayoutTestFailures.results_from_string):
(LayoutTestFailures.has_json_wrapper): Deleted.
(LayoutTestFailures.strip_json_wrapper): Deleted.
* Tools/CISupport/ews-build/layout_test_failures_unittest.py: Added.
(TestLayoutTestFailures):
(TestLayoutTestFailures.test_results_from_string_valid_jsonp):
(TestLayoutTestFailures.test_results_from_string_valid_json):
(TestLayoutTestFailures.test_results_from_string_invalid_json):
(TestLayoutTestFailures.test_results_from_string_invalid_jsonp_suffix):
(TestLayoutTestFailures.test_results_from_string_invalid_jsonp_suffix_valid_js):
(TestLayoutTestFailures.test_results_from_string_invalid_jsonp_internal):
(TestLayoutTestFailures.test_results_from_string_empty):
(TestLayoutTestFailures.test_results_from_string_ws_only):
(TestLayoutTestFailures.test_results_from_string_split_at_4096):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/271360@main