[webkit-changes] [WebKit/WebKit] 133bcb: Hide HTMLInputElement's m_hasTouchEventHandler fro...

Anne van Kesteren noreply at github.com
Thu Nov 30 09:42:21 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 133bcb02e0878c9fcec2b653740cc47d8ca0d27f
      https://github.com/WebKit/WebKit/commit/133bcb02e0878c9fcec2b653740cc47d8ca0d27f
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-11-30 (Thu, 30 Nov 2023)

  Changed paths:
    M Source/WebCore/html/HTMLInputElement.cpp
    M Source/WebCore/html/HTMLInputElement.h
    M Source/WebCore/html/InputType.cpp
    M Source/WebCore/html/InputType.h
    M Source/WebCore/html/RangeInputType.cpp
    M Source/WebCore/html/RangeInputType.h

  Log Message:
  -----------
  Hide HTMLInputElement's m_hasTouchEventHandler from IOS_TOUCH_EVENTS
https://bugs.webkit.org/show_bug.cgi?id=265567

Reviewed by Wenson Hsieh.

RangeInputType appears to be the sole consumer of this functionality
with its hasTouchEventHandler() which is hidden from iOS. So make
this more consistent throughout so less code runs on iOS.

At the same time, swap PLATFORM(IOS_FAMILY) with
ENABLE(IOS_TOUCH_EVENTS) here as that seems more logical.

* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::~HTMLInputElement):
(WebCore::HTMLInputElement::runPostTypeUpdateTasks):
(WebCore::HTMLInputElement::didMoveToNewDocument):
* Source/WebCore/html/HTMLInputElement.h:
* Source/WebCore/html/InputType.cpp:
(WebCore::InputType::handleTouchEvent): Deleted.
(WebCore::InputType::hasTouchEventHandler const): Deleted.
* Source/WebCore/html/InputType.h:
(WebCore::InputType::handleTouchEvent):
(WebCore::InputType::hasTouchEventHandler const):
* Source/WebCore/html/RangeInputType.cpp:
(WebCore::RangeInputType::handleTouchEvent):
(WebCore::RangeInputType::hasTouchEventHandler const): Deleted.
* Source/WebCore/html/RangeInputType.h:

Canonical link: https://commits.webkit.org/271346@main




More information about the webkit-changes mailing list