[webkit-changes] [WebKit/WebKit] 48c1a4: REGRESSION(271265 at main): Heap corruption crash whi...

Fujii Hironori noreply at github.com
Wed Nov 29 17:15:56 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 48c1a4c6572cddbe6fe0c673492ae50d8a5fd66e
      https://github.com/WebKit/WebKit/commit/48c1a4c6572cddbe6fe0c673492ae50d8a5fd66e
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
    M Source/WebCore/html/canvas/WebGLMultiDraw.h

  Log Message:
  -----------
  REGRESSION(271265 at main): Heap corruption crash while destructing WebGLMultiDraw
https://bugs.webkit.org/show_bug.cgi?id=265538

Unreviewed crash fix for Windows port.
Windows port was crashing after 271265 at main made WebGLExtension a
RefCounted subclass. Only WebGLMultiDraw has virtual destructor among
WebGLExtension subclasses. ~WebGLMultiDraw should be non-virtual as
well as other WebGLExtension subclasses.

* Source/WebCore/html/canvas/WebGLMultiDraw.h:
Removed virtual from ~WebGLMultiDraw.

Canonical link: https://commits.webkit.org/271315@main




More information about the webkit-changes mailing list