[webkit-changes] [WebKit/WebKit] 4e5d89: Fix some incorrect adoptNS() usage in tests

Simon Fraser noreply at github.com
Wed Nov 29 10:31:00 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e5d8928f4798bb1a78734997e52292e9ae8cff7
      https://github.com/WebKit/WebKit/commit/4e5d8928f4798bb1a78734997e52292e9ae8cff7
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SOAuthorizationTests.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm

  Log Message:
  -----------
  Fix some incorrect adoptNS() usage in tests
https://bugs.webkit.org/show_bug.cgi?id=265496
rdar://118908203

Reviewed by Chris Dumez.

Don't use adoptNS/adoptCF() with expressions that don't return a retained value.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SOAuthorizationTests.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/271287@main




More information about the webkit-changes mailing list