[webkit-changes] [WebKit/WebKit] 04aab9: [IFC][Ruby] Ensure split inlines have display:inline

Antti Koivisto noreply at github.com
Wed Nov 29 08:50:00 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 04aab9f24bf40250f7d4fcc22e864f29821bc122
      https://github.com/WebKit/WebKit/commit/04aab9f24bf40250f7d4fcc22e864f29821bc122
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
    M Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp

  Log Message:
  -----------
  [IFC][Ruby] Ensure split inlines have display:inline
https://bugs.webkit.org/show_bug.cgi?id=265514
rdar://problem/118932123

Reviewed by Alan Baradlay.

With ruby we may end up splitting inline display types other that 'inline'.
Ensure we just generate plain inlines so we don't create unexpected structures.

This fixes

fast/ruby/continuation-and-column-spanner-crash.html
fast/ruby/crash-when-ruby-base-is-collapsed.html
fast/ruby/ruby-illegal-1.html
fast/ruby/ruby-base-merge-block-children-crash.html
fast/ruby/ruby-illegal-combined.html

with style based ruby enabled.

* Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp:
(WebCore::cloneAsContinuation):

Canonical link: https://commits.webkit.org/271279@main




More information about the webkit-changes mailing list