[webkit-changes] [WebKit/WebKit] d445ae: ScriptBuffer append with empty string adds empty s...

Commit Queue noreply at github.com
Wed Nov 29 07:03:36 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d445ae96c998ea89baf151fce42f5e1ca42c09fa
      https://github.com/WebKit/WebKit/commit/d445ae96c998ea89baf151fce42f5e1ca42c09fa
  Author: Mark Lam <mark.lam at apple.com>
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
    M Source/WebCore/workers/ScriptBuffer.cpp
    M Source/WebCore/workers/service/server/SWScriptStorage.cpp

  Log Message:
  -----------
  ScriptBuffer append with empty string adds empty segment.
https://bugs.webkit.org/show_bug.cgi?id=264971
rdar://118752844

Reviewed by Youenn Fablet and Dan Glastonbury.

We should avoid adding empty strings to reduce the possibility of unnecessary
work downstream in the consumers of the ScriptBuffer.

* Source/WebCore/workers/ScriptBuffer.cpp:
(WebCore::ScriptBuffer::append):
* Source/WebCore/workers/service/server/SWScriptStorage.cpp:
(WebCore::SWScriptStorage::store):

Canonical link: https://commits.webkit.org/271275@main




More information about the webkit-changes mailing list