[webkit-changes] [WebKit/WebKit] 98e1d7: m_parser can be concurrently accessed by SourceBuf...

Jean-Yves Avenard noreply at github.com
Wed Nov 29 04:41:00 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 98e1d755018293a1f7f31a544f19aa7b60d4c10b
      https://github.com/WebKit/WebKit/commit/98e1d755018293a1f7f31a544f19aa7b60d4c10b
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.h
    M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm
    M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h
    M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm
    M Source/WebCore/platform/graphics/cocoa/SourceBufferParser.h
    M Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp
    M Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.h

  Log Message:
  -----------
  m_parser can be concurrently accessed by SourceBufferPrivateAVFObjC
https://bugs.webkit.org/show_bug.cgi?id=265503
rdar://118913735

Reviewed by Youenn Fablet.

We ensure that m_parser is only ever used on the parser queue.
Additionally, remove the non-functional SourceBufferParser::setShouldProvideMediaDataForTrackID API
and SourceBufferParser::shouldProvideMediadataForTrackID which was never used.

* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.h:
* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm:
(WebCore::SourceBufferParserAVFObjC::setShouldProvideMediaDataForTrackID): Deleted.
(WebCore::SourceBufferParserAVFObjC::shouldProvideMediadataForTrackID): Deleted.
* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::appendInternal):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeSelected):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::streamDataParser const): Deleted.
* Source/WebCore/platform/graphics/cocoa/SourceBufferParser.h:
* Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::SourceBufferParserWebM::setShouldProvideMediaDataForTrackID): Deleted.
(WebCore::SourceBufferParserWebM::shouldProvideMediadataForTrackID): Deleted.
* Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.h:

Canonical link: https://commits.webkit.org/271270@main




More information about the webkit-changes mailing list