[webkit-changes] [WebKit/WebKit] 9265f7: Followup to 270854 at main: remove some hard-coded de...
Wenson Hsieh
noreply at github.com
Tue Nov 28 19:23:21 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9265f759cab1cf9af2572363ef399153eeede692
https://github.com/WebKit/WebKit/commit/9265f759cab1cf9af2572363ef399153eeede692
Author: Wenson Hsieh <wenson_hsieh at apple.com>
Date: 2023-11-28 (Tue, 28 Nov 2023)
Changed paths:
M Source/WebKit/UIProcess/ios/WKExtendedTextInputTraits.mm
Log Message:
-----------
Followup to 270854 at main: remove some hard-coded default colors in `WKExtendedTextInputTraits`
https://bugs.webkit.org/show_bug.cgi?id=264977
rdar://118526529
Reviewed by Richard Robinson.
The following three properties:
```
-insertionPointColor
-selectionBarColor
-selectionHighlightColor
```
...are actually nullable on `UIExtendedTextInputTraits`, and setting them to `nil` allows UIKit to
fall back to default colors. As such, we can avoid hard-coding default values here and just set
these properties to `nil`.
* Source/WebKit/UIProcess/ios/WKExtendedTextInputTraits.mm:
(-[WKExtendedTextInputTraits setSelectionColorsToMatchTintColor:]):
(WebKit::defaultInsertionPointColor): Deleted.
(WebKit::defaultSelectionGrabberColor): Deleted.
(WebKit::defaultSelectionHighlightColor): Deleted.
Canonical link: https://commits.webkit.org/271257@main
More information about the webkit-changes
mailing list