[webkit-changes] [WebKit/WebKit] ed090e: [Cocoa] WebCodecs H265 decoder should reorder fram...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ed090e21829dc96a1e4d2127eb5705c859e8b8c1
      https://github.com/WebKit/WebKit/commit/ed090e21829dc96a1e4d2127eb5705c859e8b8c1
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-11-28 (Tue, 28 Nov 2023)

  Changed paths:
    A LayoutTests/http/tests/webcodecs/hevc-reordering-expected.txt
    A LayoutTests/http/tests/webcodecs/hevc-reordering.html
    M LayoutTests/platform/glib/TestExpectations
    M Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_sps_parser.cc
    M Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_sps_parser.h
    M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.mm
    M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH264.mm
    M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH265.h
    M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH265.mm
    A Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoFrameReorderQueue.h
    A Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoFrameReorderQueue.mm
    M Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj

  Log Message:
  -----------
  [Cocoa] WebCodecs H265 decoder should reorder frames according presentation time
https://bugs.webkit.org/show_bug.cgi?id=265389
rdar://problem/118836800

Reviewed by Eric Carlson.

We compute the reorder queue size by parsing SPS.
We reuse the same queue as RTCVideoDecoderH264 and, for that purpose, refactor the code in a RTCVideoFrameWithOrder class.

* LayoutTests/http/tests/webcodecs/hevc-reordering-expected.txt: Added.
* LayoutTests/http/tests/webcodecs/hevc-reordering.html: Added.
* LayoutTests/platform/glib/TestExpectations:
* Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_sps_parser.cc:
* Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_sps_parser.h:
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.mm:
(-[WK_RTCLocalVideoH264H265VP9Decoder setFormat:size:width:height:]):
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH264.mm:
(RTCFrameDecodeParams::RTCFrameDecodeParams):
(decompressionOutputCallback):
(-[RTCVideoDecoderH264 init]):
(-[RTCVideoDecoderH264 decodeData:size:timeStamp:]):
(-[RTCVideoDecoderH264 setAVCFormat:size:width:height:]):
(-[RTCVideoDecoderH264 flush]):
(-[RTCVideoDecoderH264 processFrame:reorderSize:]):
(RTCVideoFrameWithOrder::RTCVideoFrameWithOrder): Deleted.
(RTCVideoFrameWithOrder::~RTCVideoFrameWithOrder): Deleted.
(RTCVideoFrameWithOrder::take): Deleted.
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH265.h:
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH265.mm:
(RTCH265FrameDecodeParams::RTCH265FrameDecodeParams):
(spsDataFromHvcc):
(ComputeH265ReorderSizeFromSPS):
(ComputeH265ReorderSizeFromHVCC):
(ComputeH265ReorderSizeFromAnnexB):
(h265DecompressionOutputCallback):
(-[RTCVideoDecoderH265 decodeData:size:timeStamp:]):
(-[RTCVideoDecoderH265 setHVCCFormat:size:width:height:]):
(-[RTCVideoDecoderH265 resetDecompressionSession]):
(-[RTCVideoDecoderH265 flush]):
(-[RTCVideoDecoderH265 processFrame:reorderSize:]):
(-[RTCVideoDecoderH265 setAVCFormat:size:width:height:]): Deleted.
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoFrameReorderQueue.h: Added.
(webrtc::RTCVideoFrameReorderQueue::RTCVideoFrameWithOrder::RTCVideoFrameWithOrder):
(webrtc::RTCVideoFrameReorderQueue::RTCVideoFrameWithOrder::~RTCVideoFrameWithOrder):
(webrtc::RTCVideoFrameReorderQueue::RTCVideoFrameWithOrder::take):
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoFrameReorderQueue.mm: Added.
(webrtc::RTCVideoFrameReorderQueue::isEmpty):
(webrtc::RTCVideoFrameReorderQueue::reorderSize const):
(webrtc::RTCVideoFrameReorderQueue::setReorderSize):
(webrtc::RTCVideoFrameReorderQueue::append):
(webrtc::RTCVideoFrameReorderQueue::takeIfAvailable):
(webrtc::RTCVideoFrameReorderQueue::takeIfAny):
* Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/271242@main