[webkit-changes] [WebKit/WebKit] fb659a: getDisplayMedia frameRate always 30 regardless of ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fb659ad0308bd57d7bc57ef1e52cbbf1a14220a8
      https://github.com/WebKit/WebKit/commit/fb659ad0308bd57d7bc57ef1e52cbbf1a14220a8
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-11-28 (Tue, 28 Nov 2023)

  Changed paths:
    M LayoutTests/fast/mediastream/getDisplayMedia-frame-rate.html
    M Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp
    M Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.h

  Log Message:
  -----------
  getDisplayMedia frameRate always 30 regardless of constraints
https://bugs.webkit.org/show_bug.cgi?id=265305
rdar://118874132

Reviewed by Eric Carlson.

Our frame decimator is based on knowing the observed frame rate.
DisplayCaptureSourceCocoa was not implementing observedFrameRate so the frame rate decimator was not kicking in.
We implement observedFrameRate by using the frame rate used by the timer that generates frames.
We beef up the existing test and use rvfc instead of the internals API.

* LayoutTests/fast/mediastream/getDisplayMedia-frame-rate.html:
* Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp:
(WebCore::DisplayCaptureSourceCocoa::observedFrameRate const):
* Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.h:

Canonical link: https://commits.webkit.org/271233@main