[webkit-changes] [WebKit/WebKit] cabc67: Don't fall back to legacy event handling logic in ...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cabc6752c8386048f2ae8ce3ef739c98a5910543
      https://github.com/WebKit/WebKit/commit/cabc6752c8386048f2ae8ce3ef739c98a5910543
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-11-28 (Tue, 28 Nov 2023)

  Changed paths:
    M Source/WebKit/Platform/spi/ios/UIKitSPI.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  Don't fall back to legacy event handling logic in -_interpretKeyEvent:isCharEvent: when using async text input
https://bugs.webkit.org/show_bug.cgi?id=265461

Reviewed by Megan Gardner.

Instead of using the nullity of `_asyncSystemInputDelegate` to guard async text input codepaths, we
should instead be using the feature flag (`self.shouldUseAsyncInteractions`). This should prevent us
from unintentionally falling back to legacy UIKit SPI codepaths in a handful of places below.

* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView replaceForWebView:]):

Drive-by fix: rename this again, to reflect the final name that was merged in <rdar://118307558>.

(-[WKContentView _internalBeginSelectionChange]):
(-[WKContentView _internalEndSelectionChange]):
(-[WKContentView _interpretKeyEvent:isCharEvent:]):

Canonical link: https://commits.webkit.org/271226@main