[webkit-changes] [WebKit/WebKit] 921f26: [WGSL] Constant determinant function breaks with f16

Tadeu Zagallo noreply at github.com
Tue Nov 28 06:56:51 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 921f26d0f7880a3d3a90e1afbd84b3703cb4de02
      https://github.com/WebKit/WebKit/commit/921f26d0f7880a3d3a90e1afbd84b3703cb4de02
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-11-28 (Tue, 28 Nov 2023)

  Changed paths:
    M Source/WebGPU/WGSL/ConstantFunctions.h
    M Source/WebGPU/WGSL/tests/valid/overload.wgsl

  Log Message:
  -----------
  [WGSL] Constant determinant function breaks with f16
https://bugs.webkit.org/show_bug.cgi?id=265394
rdar://118843391

Reviewed by Mike Wyrzykowski.

The helper lambads in constantDeterminant need to explicitly type the result
as the f16/half values will be implicitly casted to float.

* Source/WebGPU/WGSL/ConstantFunctions.h:
(WGSL::CONSTANT_FUNCTION):
* Source/WebGPU/WGSL/tests/valid/overload.wgsl:

Canonical link: https://commits.webkit.org/271206@main




More information about the webkit-changes mailing list