[webkit-changes] [WebKit/WebKit] 7aa3c2: [WGSL] Constant cross function breaks with f16

Tadeu Zagallo noreply at github.com
Tue Nov 28 05:30:59 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7aa3c2dee61a758fefafb19d2472609d6af3b6ac
      https://github.com/WebKit/WebKit/commit/7aa3c2dee61a758fefafb19d2472609d6af3b6ac
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-11-28 (Tue, 28 Nov 2023)

  Changed paths:
    M Source/WebGPU/WGSL/ConstantFunctions.h
    M Source/WebGPU/WGSL/tests/valid/overload.wgsl

  Log Message:
  -----------
  [WGSL] Constant cross function breaks with f16
https://bugs.webkit.org/show_bug.cgi?id=265392
rdar://118842794

Reviewed by Mike Wyrzykowski.

We need to explicitly cast the elements of the result vector, as the f16/half
values get implicitly promoted to float.

* Source/WebGPU/WGSL/ConstantFunctions.h:
(WGSL::CONSTANT_FUNCTION):
* Source/WebGPU/WGSL/tests/valid/overload.wgsl:

Canonical link: https://commits.webkit.org/271201@main




More information about the webkit-changes mailing list