[webkit-changes] [WebKit/WebKit] d14243: [scroll-animations] ensure the `scroll-timeline` s...

Antoine Quint noreply at github.com
Tue Nov 28 00:17:14 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d142435f83e61bec4b4d59894d6388902dd511ab
      https://github.com/WebKit/WebKit/commit/d142435f83e61bec4b4d59894d6388902dd511ab
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-11-28 (Tue, 28 Nov 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-shorthand-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-shorthand.html
    M Source/WebCore/css/ShorthandSerializer.cpp

  Log Message:
  -----------
  [scroll-animations] ensure the `scroll-timeline` shorthand serializes according to the rule of a coordinating list property group
https://bugs.webkit.org/show_bug.cgi?id=265350

Reviewed by Dean Jackson.

The `scroll-timeline` shorthand property must adhere to the rules of a coordinating list property
group (see https://drafts.csswg.org/css-values-4/#linked-properties). The WPT test for serialization
of this property is incorrect (see https://github.com/web-platform-tests/wpt/issues/43336) so we
must fix it and ensure our implementation is right.

* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-shorthand-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-shorthand.html:
* Source/WebCore/css/ShorthandSerializer.cpp:
(WebCore::ShorthandSerializer::serialize):
(WebCore::ShorthandSerializer::serializeCoordinatingListPropertyGroup const): Introduce a new function
used to serialize a coordinating list property group.
(WebCore::ShorthandSerializer::serializeLayered const): Remove the logic specific to serialization of
`scroll-timeline-name` which no longer applies since this method won't be called for this property.

Canonical link: https://commits.webkit.org/271190@main




More information about the webkit-changes mailing list