[webkit-changes] [WebKit/WebKit] 1e3555: Investigate the possibility of replacing twisted h...

[James Carter Bohan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1e3555d85962434a8f26aae28cd16815ab5412b8
      https://github.com/WebKit/WebKit/commit/1e3555d85962434a8f26aae28cd16815ab5412b8
  Author: James Bohan <james at jcbohan.com>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/benchmark_runner/README.md
    M Tools/Scripts/webkitpy/benchmark_runner/generic_factory.py
    A Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/builtin_http_server.py
    M Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py
    M Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py
    M Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py

  Log Message:
  -----------
  Investigate the possibility of replacing twisted http server in run-benchmark with python3 http.server
https://bugs.webkit.org/show_bug.cgi?id=259835

Reviewed by Stephanie Lewis.

This is an implementation of the python 3 http.server library as the server hosting benchmark requests. This would possibly replace the implementation where the http server is being run through the externl library, twisted.
Running the http server is behind the new optional flag "--http-server-type" which takes in arguments "twisted" or "base" and will launch the http server when you put in as the argument. If the flag is not used it will default to using the twisted http server.
Requirements for if twisted is installed will only be checked for when running the twisted http server.

* Tools/Scripts/webkitpy/benchmark_runner/README.md:
* Tools/Scripts/webkitpy/benchmark_runner/generic_factory.py:
(GenericFactory.create):
* Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/builtin_http_server.py: Added.
(Handler):
(Handler.__init__):
(Handler.server_shutdown):
(Handler.log_message):
(Handler.do_GET):
(Handler.do_POST):
* Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
(SimpleHTTPServerDriver.__init__):
(SimpleHTTPServerDriver.serve):
(SimpleHTTPServerDriver.set_http_server_type):
(SimpleHTTPServerDriver._ensure_http_server_dependencies):
* Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py:
(config_argument_parser):
(run_benchmark_plan):
* Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
(WebServerBenchmarkRunner.__init__):
(WebServerBenchmarkRunner):

Canonical link: https://commits.webkit.org/271176@main