[webkit-changes] [WebKit/WebKit] b6d576: Use dynamicDowncast<T> more in RenderTheme

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b6d576d54824560544da2e793ca9625b54d1989b
      https://github.com/WebKit/WebKit/commit/b6d576d54824560544da2e793ca9625b54d1989b
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M Source/WTF/wtf/Ref.h
    M Source/WTF/wtf/RefPtr.h
    M Source/WebCore/rendering/RenderTheme.cpp
    M Source/WebCore/rendering/RenderThemeIOS.mm
    M Source/WebCore/rendering/RenderThemeMac.mm

  Log Message:
  -----------
  Use dynamicDowncast<T> more in RenderTheme
https://bugs.webkit.org/show_bug.cgi?id=265299

Reviewed by Chris Dumez and Darin Adler.

A few instances of downcast<T> remain due to asserts or not being
preceded by an equivalent is<T> check.

Also use RefPtr where possible and use clearer variable names for
impacted methods.

This includes a change by cdumez to Ref and RefPtr that makes the
various downcast methods work with const.

* Source/WTF/wtf/Ref.h:
(WTF::checkedDowncast):
(WTF::downcast):
(WTF::dynamicDowncast):
* Source/WTF/wtf/RefPtr.h:
(WTF::checkedDowncast):
(WTF::downcast):
(WTF::dynamicDowncast):
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::autoAppearanceForElement const):
(WebCore::RenderTheme::extractControlStyleForRenderer const):
(WebCore::RenderTheme::isChecked const):
(WebCore::RenderTheme::isIndeterminate const):
(WebCore::RenderTheme::isEnabled const):
(WebCore::RenderTheme::isFocused const):
(WebCore::RenderTheme::isPresenting const):
(WebCore::RenderTheme::hasListButton const):
(WebCore::RenderTheme::hasListButtonPressed const):
(WebCore::RenderTheme::paintSliderTicks):
* Source/WebCore/rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::adjustTextFieldStyle const):
(WebCore::RenderThemeIOS::paintTextFieldDecorations):
(WebCore::RenderThemeIOS::adjustMenuListButtonStyle const):
(WebCore::RenderThemeIOS::paintSliderTrack):
(WebCore::RenderThemeIOS::paintProgressBar):
(WebCore::RenderThemeIOS::isSubmitStyleButton const):
(WebCore::RenderThemeIOS::paintAttachment):
(WebCore::RenderThemeIOS::paintMeter):
(WebCore::RenderThemeIOS::paintSliderTicks):
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintAttachment):

Canonical link: https://commits.webkit.org/271170@main