[webkit-changes] [WebKit/WebKit] ce815e: Links using a border-bottom instead of text-decora...

Etienne Segonzac noreply at github.com
Mon Nov 27 13:28:46 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ce815ebcee431e984977ea22d1eec549ea29c100
      https://github.com/WebKit/WebKit/commit/ce815ebcee431e984977ea22d1eec549ea29c100
  Author: Etienne Segonzac <sgz at apple.com>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M LayoutTests/interaction-region/inline-link-expected.txt
    M LayoutTests/interaction-region/inline-link.html
    M Source/WebCore/page/InteractionRegion.cpp

  Log Message:
  -----------
  Links using a border-bottom instead of text-decoration should still get the default InteractionRegion border-radius
https://bugs.webkit.org/show_bug.cgi?id=265040
<rdar://118173683>

Reviewed by Tim Horton.

Instead of opting out of the default radius if any visible border is
present, check to see if the visible borders form a box around the
element.

* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::interactionRegionForRenderedRegion):
Introduce a specific check to gate the default radius and region
inflation instead of relying on `hasVisibleBoxDecorations()`.

* LayoutTests/interaction-region/inline-link-expected.txt:
* LayoutTests/interaction-region/inline-link.html:
Update the test to cover this case.

Canonical link: https://commits.webkit.org/271167@main




More information about the webkit-changes mailing list