[webkit-changes] [WebKit/WebKit] 07f2e6: Fix keyboard scrolling after 269941 at main

Alex Christensen noreply at github.com
Mon Nov 27 12:14:22 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 07f2e6aa57a55fc278f11a9d562b12fd371cf5ae
      https://github.com/WebKit/WebKit/commit/07f2e6aa57a55fc278f11a9d562b12fd371cf5ae
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.cpp
    M Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.h
    M Source/WebCore/page/scrolling/ScrollingStateNode.h
    M Source/WebCore/page/scrolling/ScrollingStateOverflowScrollingNode.cpp
    M Source/WebCore/page/scrolling/ScrollingStateOverflowScrollingNode.h
    M Source/WebCore/page/scrolling/ScrollingStatePluginScrollingNode.cpp
    M Source/WebCore/page/scrolling/ScrollingStatePluginScrollingNode.h
    M Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.serialization.in

  Log Message:
  -----------
  Fix keyboard scrolling after 269941 at main
https://bugs.webkit.org/show_bug.cgi?id=265396
rdar://118453548

Reviewed by Simon Fraser.

I didn't quite get the KeyboardScrollData hooked up correctly in that PR.
I thought it might need a structural refactoring, but I was wrong.
This restores behavior to how it was before that PR.

* Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.cpp:
(WebCore::ScrollingStateFrameScrollingNode::ScrollingStateFrameScrollingNode):
* Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.h:
* Source/WebCore/page/scrolling/ScrollingStateNode.h:
* Source/WebCore/page/scrolling/ScrollingStateOverflowScrollingNode.cpp:
(WebCore::ScrollingStateOverflowScrollingNode::ScrollingStateOverflowScrollingNode):
* Source/WebCore/page/scrolling/ScrollingStateOverflowScrollingNode.h:
* Source/WebCore/page/scrolling/ScrollingStatePluginScrollingNode.cpp:
(WebCore::ScrollingStatePluginScrollingNode::ScrollingStatePluginScrollingNode):
* Source/WebCore/page/scrolling/ScrollingStatePluginScrollingNode.h:
* Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.serialization.in:

Canonical link: https://commits.webkit.org/271160@main




More information about the webkit-changes mailing list