[webkit-changes] [WebKit/WebKit] dd07b2: [UIAsyncTextInput] fast/forms/caps-lock-indicator-...

Wenson Hsieh noreply at github.com
Mon Nov 27 11:35:46 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dd07b27ea919520ca582d087b2bb4d414bfca6d4
      https://github.com/WebKit/WebKit/commit/dd07b27ea919520ca582d087b2bb4d414bfca6d4
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M Source/WebCore/platform/ios/WebEvent.mm
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  [UIAsyncTextInput] fast/forms/caps-lock-indicator-width.html fails with --use-async-uikit-interactions
https://bugs.webkit.org/show_bug.cgi?id=265357
rdar://118809857

Reviewed by Megan Gardner.

Fix this failing layout test when async UIKit interactions are enabled; see below.

* Source/WebCore/platform/ios/WebEvent.mm:
(webEventModifierFlags):

Add missing logic to handle `UIKeyModifierAlphaShift` (i.e. caps lock state) by adding the
`WebEventFlagMaskLeftCapsLockKey` modifier flag.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView insertionPointColor]):
(-[WKContentView selectionBarColor]):
(-[WKContentView selectionHighlightColor]):
(-[WKContentView textContentTypeForTesting]):

Replace internal calls into the private `-textInputTraits` method here, to avoid hitting our own
release assert.

Canonical link: https://commits.webkit.org/271157@main




More information about the webkit-changes mailing list