[webkit-changes] [WebKit/WebKit] 0454da: [MediaStream] Address review comments after 270621...

Eric Carlson noreply at github.com
Mon Nov 27 11:26:25 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0454dad1fb7bd693076bce3a6102e11aa0d0e29f
      https://github.com/WebKit/WebKit/commit/0454dad1fb7bd693076bce3a6102e11aa0d0e29f
  Author: Eric Carlson <eric.carlson at apple.com>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
    M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
    M Source/WebCore/platform/mock/MockRealtimeVideoSource.h
    M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp

  Log Message:
  -----------
  [MediaStream] Address review comments after 270621 at main
https://bugs.webkit.org/show_bug.cgi?id=265378
rdar://118832787

Reviewed by Youenn Fablet.

* Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::applyConstraints): Resolve or reject promise in a task.
(WebCore::MediaStreamTrack::trackEnded): Wrap long comment.

* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::resolvePendingPhotoRequest): Log an error message if there
is no producer.
(WebCore::AVVideoCaptureSource::rejectPendingPhotoRequest): Ditto.
(WebCore::AVVideoCaptureSource::captureOutputDidFinishProcessingPhoto): Return early if
capture fails.

* Source/WebCore/platform/mock/MockRealtimeVideoSource.h:
(WebCore::MockRealtimeVideoSource::DrawingState::DrawingState): Add `explicit`

* Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::takePhoto):

Canonical link: https://commits.webkit.org/271155@main




More information about the webkit-changes mailing list