[webkit-changes] [WebKit/WebKit] d709a5: Remove LineHeightUnitsEnabled preference

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d709a5d8a2090d8a93d8366f8dd79928e25b1ce9
      https://github.com/WebKit/WebKit/commit/d709a5d8a2090d8a93d8366f8dd79928e25b1ce9
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/css/parser/CSSParserToken.cpp
    M Source/WebCore/page/DeprecatedGlobalSettings.h
    M Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
    M Source/WebKitLegacy/mac/WebView/WebPreferences.mm
    M Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h

  Log Message:
  -----------
  Remove LineHeightUnitsEnabled preference
https://bugs.webkit.org/show_bug.cgi?id=265346
rdar://118799769

Reviewed by Darin Adler.

This has been enabled for more than a year now, and there is really no reason to turn this feature off.

Remove it to reduce the uses of DeprecatedGlobalSettings.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/css/parser/CSSParserToken.cpp:
(WebCore::cssPrimitiveValueUnitFromTrie):
* Source/WebCore/page/DeprecatedGlobalSettings.h:
(WebCore::DeprecatedGlobalSettings::setLineHeightUnitsEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::lineHeightUnitsEnabled): Deleted.
* Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h:
* Source/WebKitLegacy/mac/WebView/WebPreferences.mm:
(-[WebPreferences lineHeightUnitsEnabled]):
(-[WebPreferences setLineHeightUnitsEnabled:]):
* Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:

Canonical link: https://commits.webkit.org/271143@main