[webkit-changes] [WebKit/WebKit] 073d84: Text in flex items not breaking under specific con...

Alan Baradlay noreply at github.com
Sun Nov 26 09:43:09 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 073d84471418168eda3529985a9480621227e52f
      https://github.com/WebKit/WebKit/commit/073d84471418168eda3529985a9480621227e52f
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-11-26 (Sun, 26 Nov 2023)

  Changed paths:
    A LayoutTests/fast/text/flexing-content-fails-with-zero-width-space-expected.html
    A LayoutTests/fast/text/flexing-content-fails-with-zero-width-space.html
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderText.cpp
    M Source/WebCore/rendering/RenderText.h

  Log Message:
  -----------
  Text in flex items not breaking under specific conditions
https://bugs.webkit.org/show_bug.cgi?id=265252
<rdar://problem/118796634>

Reviewed by Antti Koivisto.

"zero width space" character (ZWSP) is a non-whitespace space character and is a word boundary.

This patch ensures legacy preferred with computation treats "zero width space" as a breakable position.

* LayoutTests/fast/text/flexing-content-fails-with-zero-width-space-expected.html: Added.
* LayoutTests/fast/text/flexing-content-fails-with-zero-width-space.html: Added.
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::isSpaceAccordingToStyle):
(WebCore::RenderText::computePreferredLogicalWidths):

Canonical link: https://commits.webkit.org/271122@main




More information about the webkit-changes mailing list