[webkit-changes] [WebKit/WebKit] 8c078c: [UIAsyncTextInput] Adopt new unprefixed responder ...

Wenson Hsieh noreply at github.com
Sun Nov 26 08:43:34 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8c078c7748a666fa6c3d57152d4a7d86fa89d460
      https://github.com/WebKit/WebKit/commit/8c078c7748a666fa6c3d57152d4a7d86fa89d460
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-11-26 (Sun, 26 Nov 2023)

  Changed paths:
    M Source/WebKit/Platform/spi/ios/UIKitSPI.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  [UIAsyncTextInput] Adopt new unprefixed responder action names
https://bugs.webkit.org/show_bug.cgi?id=265117
rdar://118631896

Reviewed by Megan Gardner.

Adopt the following unprefixed responder action selector names:

`-_addShortcut:`            →    `-addShortcut:`
`-_define:`                 →    `-define:`
`-_promptForReplace:`       →    `-promptForReplace:`
`-_share:`                  →    `-share:`
`-_translate:`              →    `-translate:`
`-_transliterateChinese:`   →    `-transliterateChinese:`
`-_findSelected:`           →    `-findSelected:`

...while maintaining compatibility with the legacy, underscore-prefixed versions.

* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _lookupForWebView:]):

Since `-_lookup:` was only used as an alias for `_define:`, there's no new, unprefixed name that
corresponds to this selector. Instead, we simply call through to `-defineForWebView:`.

(-[WKContentView defineForWebView:]):
(-[WKContentView _shareForWebView:]):
(-[WKContentView shareForWebView:]):
(-[WKContentView _translateForWebView:]):
(-[WKContentView translateForWebView:]):
(-[WKContentView _addShortcutForWebView:]):
(-[WKContentView addShortcutForWebView:]):
(-[WKContentView _promptForReplaceForWebView:]):
(-[WKContentView promptForReplaceForWebView:]):

Add the corresponding unprefixed `-actionForWebView:` methods on the content view as well, and make
the legacy underscore-prefixed methods wrap these new names (while release asserting that the async
text input feature flag is disabled).

(-[WKContentView _transliterateChineseForWebView:]):
(-[WKContentView transliterateChineseForWebView:]):
(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView _defineForWebView:]):
(-[WKContentView _findSelectedForWebView:]):
(-[WKContentView findSelectedForWebView:]):

Canonical link: https://commits.webkit.org/271119@main




More information about the webkit-changes mailing list