[webkit-changes] [WebKit/WebKit] 5d05c3: [cssom] Fix serialization of identity transforms i...

Tim Nguyen noreply at github.com
Sat Nov 25 12:56:53 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5d05c38e6daa65ede4f6963a40d8be06ee2fba46
      https://github.com/WebKit/WebKit/commit/5d05c38e6daa65ede4f6963a40d8be06ee2fba46
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-11-25 (Sat, 25 Nov 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/rotate-parsing-computed-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/rotate-parsing-computed.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/scale-parsing-computed-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/scale-parsing-computed.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/translate-parsing-computed-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/translate-parsing-computed.html
    M Source/WebCore/css/ComputedStyleExtractor.cpp

  Log Message:
  -----------
  [cssom] Fix serialization of identity transforms in individual transform functions
https://bugs.webkit.org/show_bug.cgi?id=265267
rdar://118727471

Reviewed by Darin Adler.

`translate: 0px` should not compute to `translate: none`. Same for `rotate: 0deg` or `scale: 1`.

The identity transforms are not the same as `none` because they are supposed to generate a stacking context.

This also recovers the Interop 2023 Math functions score to 99% after https://github.com/web-platform-tests/wpt/commit/f00b5b0.

* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/rotate-parsing-computed-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/rotate-parsing-computed.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/scale-parsing-computed-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/scale-parsing-computed.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/translate-parsing-computed-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/translate-parsing-computed.html: Added.
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::computedTranslate):
(WebCore::computedScale):
(WebCore::computedRotate):

Canonical link: https://commits.webkit.org/271115@main




More information about the webkit-changes mailing list