[webkit-changes] [WebKit/WebKit] 55edb4: [IFC] Inappropriate word order in the Arabic-Engli...

Alan Baradlay noreply at github.com
Sat Nov 25 08:56:42 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 55edb4c6289e9239db0cf985720a6f60d4980b4a
      https://github.com/WebKit/WebKit/commit/55edb4c6289e9239db0cf985720a6f60d4980b4a
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-11-25 (Sat, 25 Nov 2023)

  Changed paths:
    A LayoutTests/fast/text/bidi-content-with-normal-inline-box-mispositioned-expected.html
    A LayoutTests/fast/text/bidi-content-with-normal-inline-box-mispositioned.html
    M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp

  Log Message:
  -----------
  [IFC] Inappropriate word order in the Arabic-English dictionary
https://bugs.webkit.org/show_bug.cgi?id=265332
<rdar://99087118>

Reviewed by Antti Koivisto.

Inline box start/end markers with non-default unicode-bidi values do not participate in bidi reordering (they don't
inject control characters to initiate isolation/embedding). We also set their bidi levels to opaque to ensue ICU does not get confused while
running reordering.
However inline box start/end makers with injected control characters (e.g. <span style="unicode-bidi: isolate">isolated</span)
should keep their ICU assigned bidi level values for reordering.

* LayoutTests/fast/text/bidi-content-with-normal-inline-box-mispositioned-expected.html: Added.
* LayoutTests/fast/text/bidi-content-with-normal-inline-box-mispositioned.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::buildBidiParagraph):

Canonical link: https://commits.webkit.org/271112@main




More information about the webkit-changes mailing list