[webkit-changes] [WebKit/WebKit] e94cf1: [LBSE] Fix clipping + SVGUseElement support

Nikolas Zimmermann noreply at github.com
Fri Nov 24 08:33:00 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e94cf196874e3b91550e8f4a3bf5c44aa318798a
      https://github.com/WebKit/WebKit/commit/e94cf196874e3b91550e8f4a3bf5c44aa318798a
  Author: Nikolas Zimmermann <nzimmermann at igalia.com>
  Date:   2023-11-24 (Fri, 24 Nov 2023)

  Changed paths:
    M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations
    M Source/WebCore/rendering/svg/SVGPathData.cpp
    M Source/WebCore/svg/SVGClipPathElement.cpp
    M Source/WebCore/svg/SVGGraphicsElement.cpp
    M Source/WebCore/svg/SVGUseElement.cpp
    M Source/WebCore/svg/SVGUseElement.h

  Log Message:
  -----------
  [LBSE] Fix clipping + SVGUseElement support
https://bugs.webkit.org/show_bug.cgi?id=265244

Reviewed by Rob Buis.

Teach pathFromGraphicsElement() about SVGUseElement, and use that
to support <use> as <clipPath> children in LBSE. The legacy SVG
engine uses the deprecated virtual SVGUseElement::toClipPath()
function -- LBSE no longer makes use of these code paths.

Covered by existing tests - 5+ fixed tests in LBSE.

* LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations:
* Source/WebCore/rendering/svg/SVGPathData.cpp:
(WebCore::pathFromUseElement):
(WebCore::pathFromGraphicsElement):
* Source/WebCore/svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::shouldApplyPathClipping const):
* Source/WebCore/svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::toClipPath):
* Source/WebCore/svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::toClipPath):
(WebCore::SVGUseElement::clipChild const):
* Source/WebCore/svg/SVGUseElement.h:

Canonical link: https://commits.webkit.org/271101@main




More information about the webkit-changes mailing list