[webkit-changes] [WebKit/WebKit] 526697: Fix build errors due to unused values and declarat...

Adrian Perez noreply at github.com
Fri Nov 24 03:27:08 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5266976a72254295a50a7047be137de500323818
      https://github.com/WebKit/WebKit/commit/5266976a72254295a50a7047be137de500323818
  Author: Adrian Perez de Castro <aperez at igalia.com>
  Date:   2023-11-24 (Fri, 24 Nov 2023)

  Changed paths:
    M Source/JavaScriptCore/b3/B3Value.cpp
    M Source/JavaScriptCore/runtime/LiteralParser.cpp
    M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp
    M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformer.cpp
    M Source/WebCore/css/parser/CSSSelectorParser.cpp
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
    M Source/WebCore/layout/formattingContexts/table/TableLayout.cpp
    M Source/WebCore/page/OpportunisticTaskScheduler.h
    M Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp
    M Source/WebCore/svg/SVGClipPathElement.cpp
    M Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp
    M Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp

  Log Message:
  -----------
  Fix build errors due to unused values and declarations

Unreviewed build fixes.

* Source/JavaScriptCore/b3/B3Value.cpp: Guard B3ValueInternal::alwaysDumpConstructionSite
  with ASSERT_ENABLED, as it is used only inside assertions.
* Source/JavaScriptCore/runtime/LiteralParser.cpp:
(JSC::cannotBeIdentPartOrEscapeStart): Mark as [[maybe_unused]].
  reached by other code.
* Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp: Guard
  WasmB3IRGeneratorInternal::traceExecutionIncludesConstructionSite with
  ASSERT_ENABLED, as it is used only inside assertions.
* Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformer.cpp: Guard
  AES_CM_128_HMAC_SHA256_NONCE_SIZE with ASSERT_ENABLED, as it is used only
  inside assertions.
* Source/WebCore/css/parser/CSSSelectorParser.cpp: Add missing
  CSSParserIdioms.h header.
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: Remove
  variable checkContextLossHandlingDelay, as it it unused in the code.
* Source/WebCore/layout/formattingContexts/table/TableLayout.cpp: Add
  missing RenderStyleInlines.h header, to solve a linker error.
* Source/WebCore/page/OpportunisticTaskScheduler.h: Add missing
  JavaScriptCore/MarkedSpace.h header inclusion.
* Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:
  Guard deviceChangeDebounceTimerInterval variable with !USE(GSTREAMER),
  as it is unused when using GStreamer for multimedia.
* Source/WebCore/svg/SVGClipPathElement.cpp: Add missing
  SVGElementInlines.h header inclusion, to solve a linker error.
* Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
  Guard c_defaultRefreshRate with !HAVE(DISPLAY_LINK), as it is unused
  with DisplayLink enabled.
* Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:
  Remove focusedActiveWindow, as it is not used in the code.

Canonical link: https://commits.webkit.org/271093@main




More information about the webkit-changes mailing list