[webkit-changes] [WebKit/WebKit] ef16bd: VideoEncoder produces no frames with latencyMode "...

youennf noreply at github.com
Thu Nov 23 12:01:27 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ef16bd3f9b1c89053d0d975a2a8ef4e0fdbafcb4
      https://github.com/WebKit/WebKit/commit/ef16bd3f9b1c89053d0d975a2a8ef4e0fdbafcb4
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-11-23 (Thu, 23 Nov 2023)

  Changed paths:
    A LayoutTests/http/wpt/webcodecs/h264-encoder-default-config.https.any-expected.txt
    A LayoutTests/http/wpt/webcodecs/h264-encoder-default-config.https.any.html
    A LayoutTests/http/wpt/webcodecs/h264-encoder-default-config.https.any.js
    A LayoutTests/http/wpt/webcodecs/h264-encoder-default-config.https.any.worker-expected.txt
    A LayoutTests/http/wpt/webcodecs/h264-encoder-default-config.https.any.worker.html
    M LayoutTests/platform/glib/TestExpectations
    M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm

  Log Message:
  -----------
  VideoEncoder produces no frames with latencyMode "realtime" when framerate/bitrate are not given
https://bugs.webkit.org/show_bug.cgi?id=264894
rdar://118725549

Reviewed by Eric Carlson.

When frame rate and/or bitrate is not set, use default values for them.
For frame rate, we use 30 frames.
For bitrate, we use the max bit rate as per H264 table A.1.

* LayoutTests/http/wpt/webcodecs/h264-encoder-default-config.https.any-expected.txt: Added.
* LayoutTests/http/wpt/webcodecs/h264-encoder-default-config.https.any.html: Added.
* LayoutTests/http/wpt/webcodecs/h264-encoder-default-config.https.any.js: Added.
(async encoderTest):
(promise_test.async return):
(promise_test):
* LayoutTests/http/wpt/webcodecs/h264-encoder-default-config.https.any.worker-expected.txt: Added.
* LayoutTests/http/wpt/webcodecs/h264-encoder-default-config.https.any.worker.html: Added.
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
(-[RTCVideoEncoderH264 startEncodeWithSettings:numberOfCores:]):
(-[RTCVideoEncoderH264 setBitrate:framerate:]):
(-[RTCVideoEncoderH264 setEncoderBitrateBps:frameRate:]):

Canonical link: https://commits.webkit.org/271087@main




More information about the webkit-changes mailing list