[webkit-changes] [WebKit/WebKit] 183e4e: [CMake] build-webkit script should check env var B...

Carlos Alberto Lopez Perez noreply at github.com
Thu Nov 23 11:24:30 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 183e4e8088afa05f89b20abaea478c90f0842cff
      https://github.com/WebKit/WebKit/commit/183e4e8088afa05f89b20abaea478c90f0842cff
  Author: Carlos Alberto Lopez Perez <clopez at igalia.com>
  Date:   2023-11-23 (Thu, 23 Nov 2023)

  Changed paths:
    M Tools/Scripts/webkitdirs.pm

  Log Message:
  -----------
  [CMake] build-webkit script should check env var BUILD_WEBKIT_ARGS when checking if the cache should be cleaned
https://bugs.webkit.org/show_bug.cgi?id=264808

Reviewed by Philippe Normand.

The script build-webkit caches the parameters passed to it in order to
clean the CMake cache if the developer changes those from one invocation
to the next one.

The issue is that we support passing parameters also via the environment
variable BUILD_WEBKIT_ARGS (which we use on the bots), but we were not
checking the values from this env var when cleaning the cache.

Fix it to also take into account the values passed via this env variable.

* Tools/Scripts/webkitdirs.pm:
(shouldRemoveCMakeCache):

Canonical link: https://commits.webkit.org/271085@main




More information about the webkit-changes mailing list