[webkit-changes] [WebKit/WebKit] 6abef0: RemoteRealtimeMediaSourceProxy should use latest s...

youennf noreply at github.com
Thu Nov 23 02:48:47 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6abef0032d2b2b4d390ae4a11ba256d76cd88607
      https://github.com/WebKit/WebKit/commit/6abef0032d2b2b4d390ae4a11ba256d76cd88607
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-11-23 (Thu, 23 Nov 2023)

  Changed paths:
    M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.cpp
    M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h
    M Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm
    M Tools/TestWebKitAPI/Tests/WebKit/getUserMedia.html

  Log Message:
  -----------
  RemoteRealtimeMediaSourceProxy should use latest successful constraints when creating the remote source
https://bugs.webkit.org/show_bug.cgi?id=265232
rdar://118708700

Reviewed by Eric Carlson and Jean-Yves Avenard.

In case of GPUProcess crash, we are recreating a remote source by calling RemoteRealtimeMediaSourceProxy::createRemoteMediaSource.
createRemoteMediaSource is currently using the constraints used initially (via getUserMedia).
But it should in fact use the last successful constraints applied to the previous remote source (via applyConstraints).
Update the code accordingly and update API test to cover that case.

Canonical link: https://commits.webkit.org/271074@main




More information about the webkit-changes mailing list