[webkit-changes] [WebKit/WebKit] 25af3c: [WGSL] Constant function for abs is wrong for u32 ...

Tadeu Zagallo noreply at github.com
Thu Nov 23 02:03:01 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 25af3c24b4b9d4439099c2e5642a61e1a96108c1
      https://github.com/WebKit/WebKit/commit/25af3c24b4b9d4439099c2e5642a61e1a96108c1
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-11-23 (Thu, 23 Nov 2023)

  Changed paths:
    M Source/WebGPU/WGSL/ConstantFunctions.h

  Log Message:
  -----------
  [WGSL] Constant function for abs is wrong for u32 and f16
https://bugs.webkit.org/show_bug.cgi?id=265257
rdar://118724534

Reviewed by Mike Wyrzykowski.

For some reason it was casting u32 to int, when the result should be the identity.
The result type also needs to be explicit, otherwise we return f32 for f16 inputs.

* Source/WebGPU/WGSL/ConstantFunctions.h:
(WGSL::UNARY_OPERATION):

Canonical link: https://commits.webkit.org/271072@main




More information about the webkit-changes mailing list