[webkit-changes] [WebKit/WebKit] ac24f0: [UIAsyncTextInput] All modifier key events are dis...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ac24f0695930eebba7ae98f70d9ff431cb970038
      https://github.com/WebKit/WebKit/commit/ac24f0695930eebba7ae98f70d9ff431cb970038
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-11-22 (Wed, 22 Nov 2023)

  Changed paths:
    M Source/WebCore/platform/ios/WebEvent.mm

  Log Message:
  -----------
  [UIAsyncTextInput] All modifier key events are dispatched with `key` equal to `"Dead"`
https://bugs.webkit.org/show_bug.cgi?id=265270
rdar://118728755

Reviewed by Richard Robinson.

Add logic to set the `WebEventKeyboardInputModifierFlagsChanged` flag when converting a `UIKeyEvent`
to `WebEvent`, when async text input is enabled. Without this flag, we currently treat all modifier
keys as Dead key event for the purposes of `KeyEvent.key`, since we skip out on returning the
modifier key names in `keyForKeyEvent` and `keyIdentifierForKeyEvent` when creating the platform key
event.

* Source/WebCore/platform/ios/WebEvent.mm:
(isChangingKeyModifiers):
(-[WebEvent initWithUIKeyEvent:]):

Canonical link: https://commits.webkit.org/271069@main