[webkit-changes] [WebKit/WebKit] e180ca: [CSS-Sizing] Fix to respect block size with max-co...

Ahmad Saleem noreply at github.com
Wed Nov 22 07:12:47 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e180ca76e7e0337d925a231b4d8759369fabda6d
      https://github.com/WebKit/WebKit/commit/e180ca76e7e0337d925a231b4d8759369fabda6d
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-11-22 (Wed, 22 Nov 2023)

  Changed paths:
    R LayoutTests/fast/css-intrinsic-dimensions/height-css-tables-collapsed-expected.html
    R LayoutTests/fast/css-intrinsic-dimensions/height-css-tables-collapsed.html
    R LayoutTests/fast/css-intrinsic-dimensions/height-tables-collapsed-expected.html
    R LayoutTests/fast/css-intrinsic-dimensions/height-tables-collapsed.html
    M LayoutTests/imported/w3c/resources/import-expectations.json
    A LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/block-size-with-min-or-max-content-table-1a-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/block-size-with-min-or-max-content-table-1a.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/block-size-with-min-or-max-content-table-1b-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/block-size-with-min-or-max-content-table-1b.html
    M Source/WebCore/rendering/RenderTable.cpp

  Log Message:
  -----------
  [CSS-Sizing] Fix to respect block size with max-content and min-content in a table

https://bugs.webkit.org/show_bug.cgi?id=261986

Reviewed by Antti Koivisto.

This patch aligns WebKit with Blink / Chromium and Gecko / Firefox.

Partial Merge (only RenderTable.cpp): https://chromium.googlesource.com/chromium/src.git/+/3a0c4adda19bade345ca115fdcfe825acf0b8869

The specification [1] says to treat the 'min-content', 'max-content' and 'fit-content' values
as the initial value of the property in question, if said property is a block length property.
In other words, these CSS values really only make a difference in the inline direction.

[1] https://www.w3.org/TR/css-sizing-3/#column-sizing

Additionally, it syncs latest test copies from WPT upstream:

Upstream Hash: 708e132acaee153316bf9356b0b2ba64c40a2965

* Source/WebCore/rendering/RenderTable.cpp:
(RenderTable::layout):
* LayoutTests/imported/w3c/resources/import-expectations.json:
* LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/block-size-with-min-or-max-content-table-1a.html: Add Test Case
* LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/block-size-with-min-or-max-content-table-1a-expected.html: Add Test Case Expectation
* LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/block-size-with-min-or-max-content-table-1b.html: Add Test Case
* LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/block-size-with-min-or-max-content-table-1b-expected.html: Add Test Case Expectation
* LayoutTests/fast/css-intrinsic-dimensions/height-tables-collapsed.html: Removed in favor of WPT test
* LayoutTests/fast/css-intrinsic-dimensions/height-tables-collapsed-expected.html: Removed Expectation
* LayoutTests/fast/css-intrinsic-dimensions/height-css-tables-collapsed.html: Removed in favor of WPT test
* LayoutTests/fast/css-intrinsic-dimensions/height-css-tables-collapsed-expected.html: Removed Expectation

Canonical link: https://commits.webkit.org/271054@main




More information about the webkit-changes mailing list