[webkit-changes] [WebKit/WebKit] ec1d30: Sync 'moveBy' and 'moveTo' with CSSOM-View WebIDL ...

Ahmad Saleem noreply at github.com
Mon Nov 20 19:15:57 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ec1d30359a7e5e112a884b18bf12bb2865acf05f
      https://github.com/WebKit/WebKit/commit/ec1d30359a7e5e112a884b18bf12bb2865acf05f
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-11-20 (Mon, 20 Nov 2023)

  Changed paths:
    M LayoutTests/fast/dom/Window/window-resize-and-move-arguments-expected.txt
    M LayoutTests/fast/dom/Window/window-resize-and-move-arguments.html
    M LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt
    M LayoutTests/fast/dom/non-numeric-values-numeric-parameters.html
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/idlharness-expected.txt
    M Source/WebCore/page/LocalDOMWindow+CSSOMView.idl
    M Source/WebCore/page/LocalDOMWindow.cpp
    M Source/WebCore/page/LocalDOMWindow.h

  Log Message:
  -----------
  Sync 'moveBy' and 'moveTo' with CSSOM-View WebIDL Specification

https://bugs.webkit.org/show_bug.cgi?id=265115

Reviewed by Chris Dumez.

This patch is to align WebKit with Gecko / Firefox, Blink / Chromium and Web-Specification [1]:

[1] https://drafts.csswg.org/cssom-view/#extensions-to-the-window-interface

In this patch, 'moveBy' and 'moveTo' are updated to 'int' rather than 'float' and
accordingly update related function calls.

* Source/WebCore/page/LocalDOMWindow.cpp:
(LocalDOMWindow::moveBy):
(LocalDOMWindow::moveTo):
* Source/WebCore/page/LocalDOMWindow.h:
* Source/WebCore/page/LocalDOMWindow+CSSOMView.idl:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/idlharness-expected.txt: Rebaselined
* LayoutTests/fast/dom/non-numeric-values-numeric-parameters.html: Rebaselined
* LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt: Rebaselined
* LayoutTests/fast/dom/Window/window-resize-and-move-arguments.html: Rebaselined
* LayoutTests/fast/dom/Window/window-resize-and-move-arguments-expected.txt: Rebaselined

Canonical link: https://commits.webkit.org/270997@main




More information about the webkit-changes mailing list