[webkit-changes] [WebKit/WebKit] d36b96: [IFC] Move "content has position dependent width" ...

Alan Baradlay noreply at github.com
Mon Nov 20 17:50:23 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d36b968cd91a8dfa963aaa1d49d6b39b0fa8af28
      https://github.com/WebKit/WebKit/commit/d36b968cd91a8dfa963aaa1d49d6b39b0fa8af28
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-11-20 (Mon, 20 Nov 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp
    M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h
    M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp
    M Source/WebCore/layout/layouttree/LayoutInlineTextBox.cpp
    M Source/WebCore/layout/layouttree/LayoutInlineTextBox.h
    M Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp
    M Source/WebCore/layout/layouttree/LayoutTreeBuilder.h
    M Source/WebCore/rendering/RenderText.cpp
    M Source/WebCore/rendering/RenderText.h

  Log Message:
  -----------
  [IFC] Move "content has position dependent width" traversal to RenderText
https://bugs.webkit.org/show_bug.cgi?id=265143

Reviewed by Antti Koivisto.

Let's traverse the content only once when checking of whether the measured width can be cached.

* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::canCacheMeasuredWidthOnInlineTextItem):
(WebCore::Layout::InlineItemsBuilder::computeInlineTextItemWidths):
* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::TextUtil::hasPositionDependentContentWidth):
* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h:
* Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::BoxTree::createLayoutBox):
(WebCore::LayoutIntegration::BoxTree::updateContent):
* Source/WebCore/layout/layouttree/LayoutInlineTextBox.cpp:
(WebCore::Layout::InlineTextBox::InlineTextBox):
(WebCore::Layout::m_hasPositionDependentContentWidth):
(WebCore::Layout::m_canUseSimpleFontCodePath): Deleted.
* Source/WebCore/layout/layouttree/LayoutInlineTextBox.h:
(WebCore::Layout::InlineTextBox::hasPositionDependentContentWidth const):
(WebCore::Layout::InlineTextBox::updateContent):
* Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createTextBox):
(WebCore::Layout::TreeBuilder::createLayoutBox):
* Source/WebCore/layout/layouttree/LayoutTreeBuilder.h:
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::initiateFontLoadingByAccessingGlyphDataAndComputeCanUseSimplifiedTextMeasuring):
(WebCore::RenderText::setRenderedText):
* Source/WebCore/rendering/RenderText.h:
(WebCore::RenderText::setHasPositionDependentContentWidth):
(WebCore::RenderText::hasPositionDependentContentWidth const):

Canonical link: https://commits.webkit.org/270993@main




More information about the webkit-changes mailing list