[webkit-changes] [WebKit/WebKit] fc5002: Remove Quirk dead code: passive mousewheel event f...

Karl Dubost noreply at github.com
Mon Nov 20 14:31:26 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc500207b6a8518f2837de1db6fd5ffb0cf81a35
      https://github.com/WebKit/WebKit/commit/fc500207b6a8518f2837de1db6fd5ffb0cf81a35
  Author: Karl Dubost <karlcow at apple.com>
  Date:   2023-11-20 (Mon, 20 Nov 2023)

  Changed paths:
    M Source/WebCore/dom/EventTarget.cpp
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/Quirks.h

  Log Message:
  -----------
  Remove Quirk dead code: passive mousewheel event for smoothscroll.js
https://bugs.webkit.org/show_bug.cgi?id=241782
rdar://95972172

Reviewed by Antti Koivisto.

In https://github.com/whatwg/dom/issues/1088, Simon Pieters analyzed
the hack introduced by WebKit and Blink to determine if it was
necessary to implement it in Gecko, but during the investigation
he discovered that a part of the Quirk being dead code. Blink removed
this hack on June 2022.
https://bugs.chromium.org/p/chromium/issues/detail?id=1337217
It should be possible to remove it on WebKit as well.

* Source/WebCore/dom/EventTarget.cpp:
(WebCore::EventTarget::addEventListener):
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldMakeEventListenerPassive):
* Source/WebCore/page/Quirks.h:

Canonical link: https://commits.webkit.org/270987@main




More information about the webkit-changes mailing list