[webkit-changes] [WebKit/WebKit] 2f3793: [GTK][GStreamer] VA+DMABuf videos flicker

Žan Doberšek noreply at github.com
Mon Nov 20 03:27:01 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2f3793730f2293df914ef358bf926fc1001f2399
      https://github.com/WebKit/WebKit/commit/2f3793730f2293df914ef358bf926fc1001f2399
  Author: Žan Doberšek <zdobersek at igalia.com>
  Date:   2023-11-20 (Mon, 20 Nov 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h

  Log Message:
  -----------
  [GTK][GStreamer] VA+DMABuf videos flicker
https://bugs.webkit.org/show_bug.cgi?id=253807

Reviewed by Xabier Rodriguez-Calvar.

This is the dumb approach of storing references and dropping them upon new samples. It still has
flaws since the is-released check is not necessarily consistent and can lead to retained GstMemory
references, draining the decoder of available dmabuf targets for decoding.

Co-authored-by: Philippe Normand <philn at igalia.com>

* Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef):
(WTF::refGPtr<GstMemory>):
(WTF::derefGPtr<GstMemory>):
* Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h:
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Canonical link: https://commits.webkit.org/270971@main




More information about the webkit-changes mailing list